Fix pr review

Signed-off-by: obaydullahmhs <[email protected]>
kubedb · Sep 27, 2023 · c01d254 · c01d254
1 parent 14d9e81
commit c01d254
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 37 deletions.
diff --git a/apis/kubedb/v1alpha2/constants.go b/apis/kubedb/v1alpha2/constants.go
@@ -522,7 +522,7 @@ const (
 	KafkaPortNameExternal              = "external"
 	KafkaTopicNameHealth               = "kafka-health"
 	KafkaTopicDeletionThresholdOffset  = 1000
-	KafkaMaxNumberOfController         = 1000
+	KafkaControllerMaxID               = 1000
 	KafkaRESTPort                      = 9092
 	KafkaControllerRESTPort            = 9093
 	KafkaInternalRESTPort              = 29092

diff --git a/apis/ops/v1alpha1/kafka_ops_helpers.go b/apis/ops/v1alpha1/kafka_ops_helpers.go
@@ -53,10 +53,6 @@ func (k *KafkaOpsRequest) ResourcePlural() string {
 	return ResourcePluralKafkaOpsRequest
 }
 
-func (k *KafkaOpsRequest) ValidateSpecs() error {
-	return nil
-}
-
 var _ Accessor = &KafkaOpsRequest{}
 
 func (k *KafkaOpsRequest) GetRequestType() any {

diff --git a/apis/ops/v1alpha1/kafka_ops_types.go b/apis/ops/v1alpha1/kafka_ops_types.go
@@ -110,8 +110,6 @@ type KafkaHorizontalScalingTopologySpec struct {
 type KafkaVerticalScalingSpec struct {
 	// Resource spec for combined nodes
 	Node *core.ResourceRequirements `json:"node,omitempty"`
-	// Resource spec for exporter sidecar
-	Exporter *core.ResourceRequirements `json:"exporter,omitempty"`
 	// Specifies the resource spec for cluster in topology mode
 	Topology *KafkaVerticalScalingTopologySpec `json:"topology,omitempty"`
 }

diff --git a/apis/ops/v1alpha1/openapi_generated.go b/apis/ops/v1alpha1/openapi_generated.go
diff --git a/apis/ops/v1alpha1/zz_generated.deepcopy.go b/apis/ops/v1alpha1/zz_generated.deepcopy.go
diff --git a/crds/ops.kubedb.com_kafkaopsrequests.yaml b/crds/ops.kubedb.com_kafkaopsrequests.yaml
@@ -210,25 +210,6 @@ spec:
                 type: object
               verticalScaling:
                 properties:
-                  exporter:
-                    properties:
-                      limits:
-                        additionalProperties:
-                          anyOf:
-                          - type: integer
-                          - type: string
-                          pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
-                          x-kubernetes-int-or-string: true
-                        type: object
-                      requests:
-                        additionalProperties:
-                          anyOf:
-                          - type: integer
-                          - type: string
-                          pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
-                          x-kubernetes-int-or-string: true
-                        type: object
-                    type: object
                   node:
                     properties:
                       limits: