Add syncUsers field to pgbouncer api
#1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiranmoy Das Chowdhury <[email protected]>
Signed-off-by: Hiranmoy Das Chowdhury <[email protected]>
MobarakHsn
suggested changes
May 8, 2024
| @@ -118,10 +118,17 @@ const ( | |||
| ) | |||
|
|
|||
| type Databases struct { | |||
| // SyncUsers is a boolean type and when enabled, operator fetches all users created in the backend server to the | |||
| // PgBouncer server. Password changes are also synced in pgBouncer when it is enabled. | |||
There was a problem hiding this comment.
fetches Postgres users from externally managed secrets and sync them to PgBouncer.
There was a problem hiding this comment.
@MobarakHsn I got this comment from pgpool though. I already replaced the comment. Can you review it again if it's ok?
There was a problem hiding this comment.
It was previous mechanism for Pgpool now it works differently.
Signed-off-by: Hiranmoy Das Chowdhury <[email protected]>
Signed-off-by: Hiranmoy Das Chowdhury <[email protected]>
ArnobKumarSaha
requested changes
May 8, 2024
Signed-off-by: Hiranmoy Das Chowdhury <[email protected]>
ArnobKumarSaha
changed the title
syncUsers field to pgbouncer api
ArnobKumarSaha
approved these changes
May 8, 2024
tapojit047
pushed a commit
that referenced
this pull request
May 20, 2024
Signed-off-by: Hiranmoy Das Chowdhury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hiranmoy Das Chowdhury [email protected]