Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClickHouse API #1212

Merged
merged 7 commits into from
May 31, 2024
Merged

Add ClickHouse API #1212

merged 7 commits into from
May 31, 2024

Conversation

sheikh-arman
Copy link
Contributor

No description provided.

@sheikh-arman sheikh-arman force-pushed the clickhosue branch 5 times, most recently from 4b1a033 to 819dee2 Compare May 17, 2024 14:41
@sheikh-arman sheikh-arman force-pushed the clickhosue branch 5 times, most recently from a38c020 to a1f0cea Compare May 27, 2024 06:25
@sheikh-arman sheikh-arman force-pushed the clickhosue branch 2 times, most recently from 9f72569 to 85e97dd Compare May 29, 2024 06:21
apis/kubedb/v1alpha2/clickhouse_types.go Outdated Show resolved Hide resolved
apis/kubedb/v1alpha2/clickhouse_types.go Outdated Show resolved Hide resolved
apis/kubedb/v1alpha2/clickhouse_types.go Outdated Show resolved Hide resolved
apis/kubedb/v1alpha2/clickhouse_types.go Outdated Show resolved Hide resolved
apis/kubedb/v1alpha2/clickhouse_types.go Outdated Show resolved Hide resolved
apis/kubedb/v1alpha2/clickhouse_helpers.go Outdated Show resolved Hide resolved
@raihankhan raihankhan changed the title Add ClickHouse Add ClickHouse API May 29, 2024
Copy link
Contributor

@raihankhan raihankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rename all the PetName vars to PetSetName
  • Rearrange the structs

apis/kubedb/v1alpha2/clickhouse_helpers.go Outdated Show resolved Hide resolved
apis/kubedb/v1alpha2/clickhouse_helpers.go Outdated Show resolved Hide resolved
apis/kubedb/v1alpha2/clickhouse_helpers.go Outdated Show resolved Hide resolved
apis/kubedb/v1alpha2/clickhouse_types.go Outdated Show resolved Hide resolved
apis/kubedb/v1alpha2/clickhouse_types.go Outdated Show resolved Hide resolved
apis/kubedb/v1alpha2/clickhouse_types.go Outdated Show resolved Hide resolved
@sheikh-arman sheikh-arman force-pushed the clickhosue branch 2 times, most recently from c914666 to f01359e Compare May 29, 2024 12:35
Copy link
Contributor

@raihankhan raihankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: SK Ali Arman <[email protected]>
Signed-off-by: SK Ali Arman <[email protected]>
Signed-off-by: SK Ali Arman <[email protected]>
Signed-off-by: SK Ali Arman <[email protected]>
Signed-off-by: SK Ali Arman <[email protected]>
Signed-off-by: SK Ali Arman <[email protected]>
@raihankhan raihankhan merged commit b3797f4 into master May 31, 2024
5 checks passed
@raihankhan raihankhan deleted the clickhosue branch May 31, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants