Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Memcahced Authentication Constant #1355

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

Evanraisul
Copy link
Contributor

No description provided.

Copy link

gitguardian bot commented Nov 25, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14607324 Triggered Username Password ffe8581 apis/ops/v1alpha1/constant.go View secret
14607324 Triggered Username Password 5ed0679 apis/ops/v1alpha1/constant.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Signed-off-by: Muhammad Raisul Islam Evan <[email protected]>
Signed-off-by: Muhammad Raisul Islam Evan <[email protected]>
@Evanraisul Evanraisul force-pushed the memcached-rotate-auth branch from 904ee8a to ffe8581 Compare November 26, 2024 09:04
Copy link
Contributor

@raihankhan raihankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@raihankhan raihankhan merged commit cfbad6a into master Nov 27, 2024
11 checks passed
@raihankhan raihankhan deleted the memcached-rotate-auth branch November 27, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants