Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cassandra/client.go #143

Merged
merged 9 commits into from
Nov 8, 2024
Merged

Update Cassandra/client.go #143

merged 9 commits into from
Nov 8, 2024

Conversation

sabbir-hossain70
Copy link
Member

Signed-off-by: Sabbir [email protected]

Copy link
Member

@tapojit047 tapojit047 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use klog instead of log
  • Handle errors properly by returning when a error is encountered

@sabbir-hossain70 sabbir-hossain70 force-pushed the cas branch 3 times, most recently from 01f0e9c to 3436430 Compare November 7, 2024 05:36
Copy link
Member

@tapojit047 tapojit047 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log errors when you encounter one

Copy link
Member

@tapojit047 tapojit047 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ArnobKumarSaha ArnobKumarSaha merged commit e821040 into master Nov 8, 2024
5 checks passed
@ArnobKumarSaha ArnobKumarSaha deleted the cas branch November 8, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants