Pgpool backend reference change #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MobarakHsn <[email protected]>
Signed-off-by: MobarakHsn <[email protected]>
| apb := &appbinding.AppBinding{} | ||
| err := o.kc.Get(o.ctx, types.NamespacedName{ | ||
| Name: pp.Spec.PostgresRef.Name, | ||
| Namespace: pp.Spec.PostgresRef.Namespace, |
There was a problem hiding this comment.
cross namespace grant should be checked
There was a problem hiding this comment.
ignore for this release
pgpool/kubedb_client_builder.go
Outdated
| } | ||
| if apb.Spec.Secret == nil { | ||
| return "", "", fmt.Errorf("backend postgres database auth secret not found for pgpool %s/%s", pp.Namespace, pp.Name) |
There was a problem hiding this comment.
"backend auth secret unspecified"
Signed-off-by: MobarakHsn <[email protected]>
MobarakHsn
force-pushed
the
pgpool-fix-ref
branch
from
986b878 to
9b4d348
Compare
TasdidurRahman
previously approved these changes
Feb 27, 2024
Signed-off-by: MobarakHsn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: MobarakHsn [email protected]