Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add llm-benchmarks proposal #113

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Add llm-benchmarks proposal #113

merged 6 commits into from
Aug 29, 2024

Conversation

IcyFeather233
Copy link
Contributor

What type of PR is this?

OSPP proposal

What this PR does / why we need it:

Investigated various aspects of implementing the LLM Benchmark in Ianvs, introduced the integration plan of opencompass, and achieved the dataset map.

@IcyFeather233
Copy link
Contributor Author

By the way, my implementation is in https://github.com/IcyFeather233/ianvs/tree/dev, you can follow this readme to try llm single task learning and opencompass

@hsj576
Copy link
Member

hsj576 commented Jul 18, 2024

The PR should be translated into English to facilitate understanding by people from other countries.

@IcyFeather233
Copy link
Contributor Author

https://github.com/IcyFeather233/ianvs/tree/dev

Thanks for the advice! I will translate it after the proposal content will not be changed.

Copy link
Collaborator

@MooreZheng MooreZheng Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposal is related to #95.
Great to see a comprehensive proposal. This one is close to the final version. As discussed in the routine meeting, there might be some advices.

  1. Though the directories are clear, an architecture is still needed to clarify what is modified in this project. E.g., what is in the TestEnv, TestCase. It seems to me that at least we have made changes on the data format to support NLP. You might want to take a look at https://github.com/kubeedge/ianvs/pull/122/files for an architecture example.
  2. Prompts would have different forms, e.g., N shots. How shall we develop a prompt template to adapt all these? It looks interesting and challenging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I add my changes to ianvs core, including 2 flowcharts showing the architecture. And a more complete benchmark format is updated in the doc.

@hsj576
Copy link
Member

hsj576 commented Aug 1, 2024

/lgtm

Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Just a few comments would be considered:

  1. The revision for index in env manager of ianvs core, which should be highlighted: The proposed design also aims to support both the old and new index.
  2. The integration part of OpenCompass should also be highlighted in the structure.png. A tutorial is needed.
  3. The prompt template is extendable, including the keys and prompts, which can be also highlighted in the proposal.

Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MooreZheng MooreZheng requested a review from hsj576 August 13, 2024 03:16
@MooreZheng MooreZheng closed this Aug 14, 2024
@MooreZheng MooreZheng reopened this Aug 14, 2024
@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 14, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MooreZheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@ojuschugh1
Copy link

ojuschugh1 commented Aug 20, 2024

Hi @IcyFeather233 , @hsj576 , @MooreZheng , I wanted to discuss one thing regarding this project. Is there any way I can chat/discuss this with you? I am unable to find anyone of you on slack channel

@MooreZheng MooreZheng added kind/design Categorizes issue or PR as related to design. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2024
@MooreZheng
Copy link
Collaborator

Hi @IcyFeather233 , @hsj576 , @MooreZheng , I wanted to discuss one thing regarding this project. Is there any way I can chat/discuss this with you? I am unable to find anyone of you on slack channel

Hi, the slack channel currently has networking issues for Chinese users. You might want to leave your comment here or raise a issue.

@jaypume
Copy link
Member

jaypume commented Aug 29, 2024

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
@jaypume jaypume merged commit 1aae17f into kubeedge:main Aug 29, 2024
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants