Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves issue#170 #171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resolves issue#170 #171

wants to merge 1 commit into from

Conversation

AryanNanda17
Copy link

What type of PR is this?
/kind bug

/kind documentation

Fixes #170

@kubeedge-bot kubeedge-bot added kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. labels Jan 5, 2025
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 5, 2025
@AryanNanda17 AryanNanda17 mentioned this pull request Jan 6, 2025
Open
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2025
@AryanNanda17
Copy link
Author

I have fixed all the path errors.
Shoutout to @FuryMartin

@AryanNanda17 AryanNanda17 changed the title Resolved issue#170 Resolves issue#170 Jan 6, 2025
FuryMartin
FuryMartin approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@FuryMartin FuryMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes the path errors in the .yaml configs of PCB-AoI example.

The modification looks good to me.

@kubeedge-bot
Copy link
Collaborator

@FuryMartin: changing LGTM is restricted to collaborators

In response to this:

This PR fixes the path errors in the .yaml configs of PCB-AoI example.

The modification looks good to me.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FuryMartin
To complete the pull request process, please assign moorezheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @moorezheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AryanNanda17
path errors corrected in pcb-aoi/singletask_learning_benchmark
7047fc1 
Signed-off-by: Aryan <[email protected]>

changed train_url to train_index, test_url to test_index

Signed-off-by: Aryan <[email protected]>

Corrected the path errors

Signed-off-by: Aryan <[email protected]>

fault detection renamed to fault_detection

Signed-off-by: Aryan Nanda <[email protected]>
@AryanNanda17
Copy link
Author

AryanNanda17 commented Jan 7, 2025 •
edited
Loading

@MooreZheng @jaypume please have a look at this PR.
It is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FuryMartin FuryMartin FuryMartin approved these changes

@jaypume jaypume Awaiting requested review from jaypume

@MooreZheng MooreZheng Awaiting requested review from MooreZheng

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discussion on Ianvs Quick Start Guide Errors
3 participants
@AryanNanda17 @kubeedge-bot @FuryMartin