Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation involving pcb-aoi singletask and incremental learning corrected #182

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Documentation involving pcb-aoi singletask and incremental learning corrected #182

merged 1 commit into from
Feb 7, 2025
+67 −61

Conversation

AryanNanda17
Copy link
Contributor

@AryanNanda17 AryanNanda17 commented Feb 2, 2025 •
edited
Loading

/kind documentation
/kind bug

What this PR does / why we need it:

This PR corrects all the path conflicts that are there in ianvs documentation involving pcb-aoi singletask and incremental learning.

Fixes #178 #170 #183

@kubeedge-bot kubeedge-bot added kind/documentation Categorizes issue or PR as related to documentation. kind/bug Categorizes issue or PR as related to a bug. labels Feb 2, 2025
@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 2, 2025
@AryanNanda17
documentation involving pcb-aoi singletask and incremental learning c…
5f467b7 
…orrected

documentation involving pcb-aoi singletask and incremental learning corrected

Signed-off-by: Aryan Nanda <[email protected]>

path error corrected

Signed-off-by: Aryan Nanda <[email protected]>
hsj576
hsj576 suggested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@hsj576 hsj576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no "_" between "fault" and "detection" in the path.

docs/guides/how-to-contribute-test-environments.md Show resolved Hide resolved
@hsj576
Copy link
Member

hsj576 commented Feb 6, 2025

no "_" between "fault" and "detection" in the path.

I noticed that you renamed "fault detection" to "fault_detection." In that case, it is indeed unnecessary to remove the underscore from "fault_detection."

@hsj576
Copy link
Member

hsj576 commented Feb 6, 2025

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
MooreZheng
MooreZheng reviewed Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This work helps to polish the quick start. It is important for newcomers to have the quick start executed normally. Overall it looks fine to me.

Besides, the change from train_url to train_index in "testenv.yaml" could be discussed in a new issue, because the field of this yaml need to be consistent with Sedna.

@AryanNanda17
Copy link
Contributor Author

AryanNanda17 commented Feb 6, 2025 •
edited
Loading

@MooreZheng
Do we need any changes to this PR?
The change in code from train_url to train_index and test_url to test_index in ./examples/pcb-aoi/ is already merged by you in #171

This PR changes the corresponding documentation of #171 changes.

@MooreZheng
Copy link
Collaborator

@MooreZheng Do we need any changes to this PR? The change in code from train_url to train_index and test_url to test_index in ./examples/pcb-aoi/ is already merged by you in #171

This PR changes the corresponding documentation of #171 changes.

Good. Then this PR looks fine.

@MooreZheng
Copy link
Collaborator

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MooreZheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2025
@kubeedge-bot kubeedge-bot merged commit f0cd1d7 into kubeedge:main Feb 7, 2025
10 checks passed
This was referenced Feb 7, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MooreZheng MooreZheng MooreZheng left review comments

@hsj576 hsj576 hsj576 requested changes

Assignees

@MooreZheng MooreZheng

@hsj576 hsj576

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Dependency Management and Documentation for Ianvs
4 participants
@AryanNanda17 @hsj576 @MooreZheng @kubeedge-bot