proposal - Sedna controller enhancement #437
Conversation
Submit a first draft of proposal of sedna controller enhancement Signed-off-by: shemol <[email protected]>
…r reference correct the owner reference of joint inference objects Signed-off-by: shemol <[email protected]>
kubeedge-bot
added
the
size/L
SherlockShemol
changed the title
There was a problem hiding this comment.
This PR fixed #430
Previous comments can be found at #435
The concerns about compatibility are considered in this proposal. As mentioned in the scope, "Sedna joint inference and federated learning controller optimization only modifies the joint inference and federated learning controller codes. The controllers are decoupled from each other, and the function interface and library functions are not modified, so it will not affect the functions of other controllers. For existing application cases, since the CRD is not modified, the deployment of existing applications will not be affected."
The proposal looks good to me. We also got another lgtm at the routine meeting. It would be fine to merge now. However, the bug fix is not a trivial job. Sedna is also quite a complicated system. The proposal could be developed in a continuous manner and be modified during future implementations if needed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MooreZheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
|
@MooreZheng: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The proposal could be developed in a continuous manner and be modified during future implementations if needed. |
| var Kind = sednav1.SchemeGroupVersion.WithKind(Name) | ||
| var Kind = sednav1.SchemeGroupVersion.WithKind(KindName) | ||
|
|
There was a problem hiding this comment.
The bug fix and documentation PRs should be submitted separately. Please keep this in mind for future submissions.
There was a problem hiding this comment.
Yes, I get it.Thank you, Mr. Tang.
Thank you, Mr. Zheng.I will continue to improve the proposal and carefully implement the solution. |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #