Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

Update 01_AcquireData.ipynb #186

Closed

Conversation

GauravSarkar
Copy link
Contributor

The dataframes are stored as HDF5 files instead of pickle files as per requirements. Please kindly check and merge.This is regarging
issue #123 .

The dataframes are stored as HDF5 files instead of pickle files as per requirements. Please kindly check and merge.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla
Copy link

google-cla bot commented Oct 20, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 20, 2020
@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GauravSarkar
To complete the pull request process, please assign jlewi after the PR has been reviewed.
You can assign the PR to them by writing /assign @jlewi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GauravSarkar
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 20, 2020
@GauravSarkar
Copy link
Contributor Author

/assign @jlewi

@jlewi
Copy link
Contributor

jlewi commented Oct 20, 2020

Please combine all the PRs for switching to HDF5 into one PR. This way it is possible to review whether all the code is changed consistently to use HDF5 instead of pickle

@GauravSarkar
Copy link
Contributor Author

okay I will combine all the changes in a single PR.

@GauravSarkar
Copy link
Contributor Author

I have made changes to all the notebooks by commiting in the PR Update 02_fastai_DataBunch.ipynb

@jlewi
Copy link
Contributor

jlewi commented Apr 13, 2021

Closing this PR; Unfortunately this repo isn't really being maintained anymore.

@jlewi jlewi closed this Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants