Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mvoitko to the Kubeflow org #558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvoitko
Copy link

@mvoitko mvoitko commented Jun 29, 2022

Signed-off-by: Maksym Voitko [email protected]

pytest test_org_yaml.py

================================================================================ test session starts =================================================================================
platform darwin -- Python 3.9.5, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /Users/maksym.v/projects/internal-acls/github-orgs
plugins: flake8-1.0.7, asyncio-0.15.1, cov-2.12.0
collected 1 item                                                                                                                                                                     

test_org_yaml.py .                                                                                                                                                             [100%]

================================================================================= 1 passed in 0.33s ==================================================================================

PRs:

Signed-off-by: Maksym Voitko <[email protected]>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mvoitko
To complete the pull request process, please assign zijianjoy after the PR has been reviewed.
You can assign the PR to them by writing /assign @zijianjoy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @mvoitko. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 30, 2022
@Arhell Arhell removed their assignment Jun 30, 2022
@mvoitko
Copy link
Author

mvoitko commented Jun 30, 2022

@zijianjoy could you please review and approve?

@mvoitko
Copy link
Author

mvoitko commented Jun 30, 2022

/assign @zijianjoy

@zijianjoy
Copy link
Contributor

Please follow https://github.com/kubeflow/internal-acls#joining-kubeflow-github-organization for being added to the member list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants