Use ErrorList for validator

Signed-off-by: Kun Chang <[email protected]>
kubeflow · May 17, 2024 · 286f08b · 286f08b
1 parent c4c3eb5
commit 286f08b
Show file tree

Hide file tree

Showing 3 changed files with 369 additions and 196 deletions.
diff --git a/pkg/webhook/v1beta1/experiment/validation_webhook.go b/pkg/webhook/v1beta1/experiment/validation_webhook.go
@@ -90,7 +90,8 @@ func (v *ExperimentValidator) Handle(ctx context.Context, req admission.Request)
 		return admission.Errored(http.StatusBadRequest, err)
 	}
 
-	err = v.ValidateExperiment(inst, oldInst)
+	allErrs := v.ValidateExperiment(inst, oldInst)
+	err = allErrs.ToAggregate()
 	if err != nil {
 		return admission.Errored(http.StatusBadRequest, err)
 	}