Skip to content

Commit

Permalink
Ordered test cases in TestGetRunSpecWithHPConfigMap
Browse files Browse the repository at this point in the history
Signed-off-by: tariq-hasan <[email protected]>
  • Loading branch information
tariq-hasan committed Jun 25, 2024
1 parent 2480ef5 commit 4bc3eb5
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion pkg/controller.v1beta1/experiment/manifest/generator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,15 @@ spec:
},
}

for name, tc := range cases {
testCaseNames := []string{
"Run with valid parameters",
"Invalid ConfigMap name",
"Invalid template path in ConfigMap name",
"Invalid trial spec in ConfigMap",
}

for _, name := range testCaseNames {
tc := cases[name]
t.Run(name, func(t *testing.T) {
got, err := p.GetRunSpecWithHyperParameters(tc.instance, "trial-name", "trial-namespace", tc.parameterAssignments)
if diff := cmp.Diff(tc.wantError, err, cmpopts.EquateErrors()); len(diff) != 0 {
Expand Down

0 comments on commit 4bc3eb5

Please sign in to comment.