Add charmhub required fields and files

Adds new charmcraft.yaml that is required by charmhub.io. Also adds name field to bundle.yaml, as required by charmhub.io.
kubeflow · Jan 20, 2022 · 68e2761 · 68e2761
1 parent d3c3f08
commit 68e2761
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 6 deletions.
diff --git a/.github/workflows/test-charmed-katib.yaml b/.github/workflows/test-charmed-katib.yaml
@@ -75,6 +75,8 @@ jobs:
           juju bundle deploy --build --destructive-mode --serial
           juju wait -wvt 300
 
+          kubectl label namespace kubeflow katib-metricscollector-injection=enabled
+
       - name: Test Katib
         run: kubectl apply -f examples/v1beta1/hp-tuning/random.yaml
 

diff --git a/manifests/v1beta1/components/webhook/webhooks.yaml b/manifests/v1beta1/components/webhook/webhooks.yaml
@@ -5,7 +5,6 @@ metadata:
 webhooks:
   - name: validator.experiment.katib.kubeflow.org
     sideEffects: None
-    failurePolicy: Fail
     admissionReviewVersions:
       - v1
     clientConfig:
@@ -32,7 +31,6 @@ metadata:
 webhooks:
   - name: defaulter.experiment.katib.kubeflow.org
     sideEffects: None
-    failurePolicy: Fail
     admissionReviewVersions:
       - v1
     clientConfig:
@@ -53,7 +51,6 @@ webhooks:
           - experiments
   - name: mutator.pod.katib.kubeflow.org
     sideEffects: None
-    failurePolicy: Fail
     admissionReviewVersions:
       - v1
     clientConfig:

diff --git a/operators/bundle.yaml b/operators/bundle.yaml
@@ -1,3 +1,4 @@
+name: katib
 bundle: kubernetes
 applications:
   katib-controller: { charm: katib-controller,            scale: 1 }

diff --git a/operators/charmcraft.yaml b/operators/charmcraft.yaml
@@ -0,0 +1 @@
+type: bundle
diff --git a/operators/katib-controller/src/webhooks.yaml.j2 b/operators/katib-controller/src/webhooks.yaml.j2
@@ -5,7 +5,6 @@ metadata:
 webhooks:
   - name: validator.experiment.katib.kubeflow.org
     sideEffects: None
-    failurePolicy: Fail
     # TODO (andreyvelich): Migrate to v1 ?
     admissionReviewVersions:
       - v1beta1
@@ -34,7 +33,6 @@ metadata:
 webhooks:
   - name: defaulter.experiment.katib.kubeflow.org
     sideEffects: None
-    failurePolicy: Fail
     admissionReviewVersions:
       - v1beta1
     clientConfig:
@@ -56,7 +54,6 @@ webhooks:
           - experiments
   - name: mutator.pod.katib.kubeflow.org
     sideEffects: None
-    failurePolicy: Fail
     admissionReviewVersions:
       - v1beta1
     clientConfig: