fix

Signed-off-by: forsaken628 <[email protected]>
kubeflow · Jun 18, 2024 · 6f83d32 · 6f83d32
1 parent 2a79c3d
commit 6f83d32
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/cmd/metricscollector/v1beta1/file-metricscollector/main.go b/cmd/metricscollector/v1beta1/file-metricscollector/main.go
@@ -210,7 +210,10 @@ func watchMetricsFile(mFile string, stopRules stopRulesFlag, filters []string, f
 						if metricName != name {
 							continue
 						}
-						rules.UpdateMetric(name, metricValue)
+						err = rules.UpdateMetric(name, metricValue)
+						if err != nil {
+							klog.Fatalf("Unable to UpdateMetric %s %v", name, err)
+						}
 					}
 				}
 			}
@@ -230,7 +233,10 @@ func watchMetricsFile(mFile string, stopRules stopRulesFlag, filters []string, f
 				if err != nil {
 					klog.Fatalf("Unable to parse value %v to float for metric %v", metricValue, name)
 				}
-				rules.UpdateMetric(name, metricValue)
+				err = rules.UpdateMetric(name, metricValue)
+				if err != nil {
+					klog.Fatalf("Unable to UpdateMetric %s %v", name, err)
+				}
 			}
 		default:
 			klog.Fatalf("Format must be set to %v or %v", commonv1beta1.TextFormat, commonv1beta1.JsonFormat)