Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for tune in the katib_client module #2383

Closed
tariq-hasan opened this issue Jul 14, 2024 · 7 comments · Fixed by #2399
Closed

Add e2e test for tune in the katib_client module #2383

tariq-hasan opened this issue Jul 14, 2024 · 7 comments · Fixed by #2399
Assignees
Labels

Comments

@tariq-hasan
Copy link
Contributor

What you would like to be added?

We need to add e2e test for the tune function in the katib_client module.

Why is this needed?

References

Source

Related issues

Love this feature?

Give it a 👍 We prioritize the features with most 👍

@andreyvelich
Copy link
Member

Thank you for creating this @tariq-hasan!
/area sdk
/area testing
/remove-lifecycle needs-triage
/good-first-issue

Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Thank you for creating this @tariq-hasan!
/area sdk
/area testing
/remove-lifecycle needs-triage
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyooosukedn
Copy link

Would like to try on this :)

@andreyvelich
Copy link
Member

@kyooosukedn @tariq-hasan Do you time working on this ? I think, it would be great to have some simple test using tune API.
We can even take the getting started example: https://www.kubeflow.org/docs/components/katib/getting-started/#getting-started-with-katib-python-sdk

Similar to the Training Operator, we should just add another test to the run-e2e-experiment.py.

@kyooosukedn
Copy link

Hi @andreyvelich, sorry that it took me so long to finally work on this.. will do to try replicate this and get working.Thanks for your lead.

@andreyvelich
Copy link
Member

Thank you for your time!

@Electronic-Waste
Copy link
Member

I will work on this :)

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants