Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Kubernetes v1.23 and support Kubernetes v1.26 #2177

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I upgraded the Kubernetes dependencies to v1.26. By this PR, we drop support for the Kubernetes v1.23.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part-of #2155

Checklist:

  • Docs included if any changes are user facing

/assign @andreyvelich @johnugeorge

@tenzen-y
Copy link
Member Author

It seems that manusa/actions-setup-minikub doesn't support v1.26.

https://github.com/kubeflow/katib/actions/runs/5614686888/job/15213331797?pr=2177

So, we need to switch a way to set up minikube to https://github.com/medyagh/setup-minikube.

@tenzen-y
Copy link
Member Author

/hold

@gaocegege
Copy link
Member

/lgtm

@tenzen-y
Copy link
Member Author

@andreyvelich I rebased this PR.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tenzen-y!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 31, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 31, 2023

@tenzen-y
Copy link
Member Author

@andreyvelich Thanks for restarting the job.
Could you restart https://github.com/kubeflow/katib/actions/runs/5717370025/job/15490963428?pr=2177 as well?

@tenzen-y
Copy link
Member Author

/hold cancel

@google-oss-prow google-oss-prow bot merged commit d67c07b into kubeflow:master Jul 31, 2023
59 checks passed
@tenzen-y tenzen-y deleted the upgrade-k8s-v1.26 branch July 31, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants