Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy BO code #2246

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

andreyvelich
Copy link
Member

Fixes: #1904.
I removed legacy Bayesian Optimization code that we don't use currently.
We use Scikit Optimize for BO algorithm.

/assign @tenzen-y @johnugeorge

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreyvelich Thanks!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 6, 2023
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

@tenzen-y
Copy link
Member

tenzen-y commented Dec 6, 2023

https://github.com/kubeflow/katib/actions/runs/7104662786/job/19340162320?pr=2246 is failed.

@gaocegege Our Go test is flaky. So could you restart the test? I don't have permission to trigger the job.

@google-oss-prow google-oss-prow bot merged commit 4617346 into kubeflow:master Dec 6, 2023
59 checks passed
@andreyvelich andreyvelich deleted the remove-legacy-bo branch December 6, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused pkg/suggestion/v1beta1/bayesianoptimization
4 participants