Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dockerfiles for grpc installation for ppc64le #2290

Closed
wants to merge 1 commit into from

Conversation

aditijadhav38
Copy link

This PR targets to get the katib/suggestions built on PowerPC.
This PR is continuation of PR #2262

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aditijadhav38
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cmd/earlystopping/medianstop/v1beta1/Dockerfile Outdated Show resolved Hide resolved
cmd/earlystopping/medianstop/v1beta1/Dockerfile Outdated Show resolved Hide resolved
@aditijadhav38
Copy link
Author

@tenzen-y Could you please review the changes..

@tenzen-y
Copy link
Member

updated dockerfiles for grpc builds for powerPC compilation~ #2262

I'm still wondering if we should not support ppc64le based on this discussion: #2262 (review)

Anyway, we should resolve that discussion before we move this forward.

@aditijadhav38
Copy link
Author

updated dockerfiles for grpc builds for powerPC compilation~ #2262

I'm still wondering if we should not support ppc64le based on this discussion: #2262 (review)

Anyway, we should resolve that discussion before we move this forward.

For this, a comment has been already added #2262 (comment). Please check. Could you please add comment in that discussion if you have any more queries.

@lehrig
Copy link

lehrig commented Apr 17, 2024

@tenzen-y please refer to #2262 (comment) - does that help? As mentioned, we are happy to help maintaining, especially if anything architecture-specific comes up...

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

github-actions bot commented Aug 5, 2024

This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants