Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix katib use crds token pipeline trail template guide #2330

Merged
merged 1 commit into from
May 29, 2024

Conversation

Jerry-yz
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@Jerry-yz
Copy link
Contributor Author

Jerry-yz commented May 17, 2024

What this PR does / why we need it:
fix document update Use CRDs with Trial Template , but sync here Katib Examples with Tekton Pipelines Integration
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #
fix issue #2327
Checklist:

  • Docs included if any changes are user facing

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update @Jerry-yz!
I noticed that we have appropriate steps to support Tekton pipeline with Katib Trial here: https://www.kubeflow.org/docs/components/katib/user-guides/trial-template/#use-crds-with-trial-template
Should we just link this guide to the Katib controller section in this doc?

@Jerry-yz
Copy link
Contributor Author

Thank you for this update @Jerry-yz! I noticed that we have appropriate steps to support Tekton pipeline with Katib Trial here: https://www.kubeflow.org/docs/components/katib/user-guides/trial-template/#use-crds-with-trial-template Should we just link this guide to the Katib controller section in this doc?

i have update it, you can review it, thanks?

@andreyvelich
Copy link
Member

Thank you for your contribution @Jerry-yz!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

@Jerry-yz Please rebase your PR to fix the CI/CD.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 29, 2024
@google-oss-prow google-oss-prow bot merged commit 328bc5c into kubeflow:master May 29, 2024
60 checks passed
shashank-iitbhu pushed a commit to shashank-iitbhu/katib that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants