Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSOC] Support for various Parameter distributions in Katib #2334

Conversation

shashank-iitbhu
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2059

Checklist:

  • Docs included if any changes are user facing

@shashank-iitbhu
Copy link
Contributor Author

Hey @tenzen-y
I've drafted this proposal based on the discussion in kubeflow/katib#2059.
It's still in the early stages, and I'm learning about maintaining two versions of CRD APIs and going through codebase on how to structure v1beta2 alongside v1beta1.
I'll reach out if I have any questions.

@tenzen-y
Copy link
Member

tenzen-y commented Jun 5, 2024

Hey @tenzen-y I've drafted this proposal based on the discussion in kubeflow/katib#2059. It's still in the early stages, and I'm learning about maintaining two versions of CRD APIs and going through codebase on how to structure v1beta2 alongside v1beta1. I'll reach out if I have any questions.

Based on recent discussions, we decided to keep the v1beta1 API version, and then we will add parameter distribution API to the v1beta1 API. That would be great to collect early feedback from users.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!
I added a few comments.
/assign @tenzen-y @johnugeorge

docs/proposals/parameter-distribution.md Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
@shashank-iitbhu
Copy link
Contributor Author

/area gsoc

@shashank-iitbhu
Copy link
Contributor Author

/assign

@shashank-iitbhu shashank-iitbhu force-pushed the gsoc-proposal-parameter-distribution branch from db3526c to 485cf0a Compare July 25, 2024 09:28
@google-oss-prow google-oss-prow bot added size/L and removed size/XXL labels Jul 25, 2024
@shashank-iitbhu shashank-iitbhu force-pushed the gsoc-proposal-parameter-distribution branch from 485cf0a to d6b8838 Compare July 25, 2024 09:36
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments.

docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
@shashank-iitbhu shashank-iitbhu force-pushed the gsoc-proposal-parameter-distribution branch from 5794f01 to 3c9deb0 Compare July 30, 2024 19:55
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment for a nit.
Otherwise lgtm.

docs/proposals/parameter-distribution.md Outdated Show resolved Hide resolved
Signed-off-by: Shashank Mittal <[email protected]>

modified feasibleSpace

refactored proposal based on comments

comparison table updated

extra heading removed
@shashank-iitbhu shashank-iitbhu force-pushed the gsoc-proposal-parameter-distribution branch from a34c3b0 to d3b1f8a Compare July 31, 2024 06:34
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 31, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 51b246f into kubeflow:master Jul 31, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants