Replaced hpcloud with nxadm for tail package in Go #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariq-hasan
force-pushed
the
replace-hpcloud-with-nxadm-for-tail
branch
from
9afa15c
to
04cdc64
Compare
tenzen-y
reviewed
Jul 8, 2024
| t, _ := tail.TailFile(mFile, tail.Config{Follow: true}) | ||
| t, err := tail.TailFile(mFile, tail.Config{Follow: true, ReOpen: true}) | ||
| if err != nil { | ||
| klog.Error("Failed to open metrics file: ", err) |
There was a problem hiding this comment.
Suggested change
| klog.Error("Failed to open metrics file: ", err) | |
| klog.Error("Failed to open metrics file: %v", err) |
There was a problem hiding this comment.
The change has been added.
tariq-hasan
force-pushed
the
replace-hpcloud-with-nxadm-for-tail
branch
2 times, most recently
from
7bd56a2
to
ecaf176
Compare
Signed-off-by: tariq-hasan <[email protected]>
tariq-hasan
force-pushed
the
replace-hpcloud-with-nxadm-for-tail
branch
from
ecaf176
to
24c1bdb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shashank-iitbhu
pushed a commit
to shashank-iitbhu/katib
that referenced
this pull request
Jul 25, 2024
Signed-off-by: tariq-hasan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This issue helps to migrate the dependency of the
tailpackage inkatibfrom https://github.com/hpcloud/tail to https://github.com/nxadm/tail. This change is required becausehpcloudhas not been maintaining their implementation of thetailpackage.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2299
Checklist: