Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes isort profile to black, to be fully compatible and adds 'pkg' dir for black and flake8 #2413

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

Ygnas
Copy link
Contributor

@Ygnas Ygnas commented Aug 22, 2024

What this PR does / why we need it:
Changes isort profile to black, to be fully compatible and adds 'pkg' dir for black and flake8

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@Ygnas Ygnas changed the title Profile switch Changes isort profile to black, to be fully compatible and adds 'pkg' dir for black and flake8 Aug 22, 2024
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @Ygnas!
/lgtm
/assign @droctothorpe @kubeflow/wg-automl-leads

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0e2ba6e into kubeflow:master Aug 22, 2024
63 checks passed
@andreyvelich
Copy link
Member

@Ygnas If you can make the same change for the Training Operator, that would be great!
https://github.com/kubeflow/training-operator/blob/master/.pre-commit-config.yaml#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants