Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify namespace for kserve web app configmap #2151

Closed
wants to merge 1 commit into from

Conversation

annajung
Copy link
Member

Which issue is resolved by this Pull Request:
During the installation of v1.5.0-rc.1, noticed that kserve-models-web-app fails to start due to config error. Configmap needed for kserve web app is applied to default namespace instead of kserve namespace

Description of your changes:

  • Specify namespace for kserve web app configmap

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: annajung
To complete the pull request process, please assign yuzisun after the PR has been reviewed.
You can assign the PR to them by writing /assign @yuzisun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@surajkota
Copy link
Contributor

#2146

@kimwnasptd
Copy link
Member

Thanks for the PR Anna! Could you instead make it to the app's repo? https://github.com/kserve/models-web-app

You can make the PR directly to the release-0.7 branch, and I'll cherry-pick it later on to master.

I also want to include kserve/models-web-app#32, so we can include everything with one PR in the manifests

@annajung
Copy link
Member Author

annajung commented Mar 3, 2022

@kimwnasptd it's been moved to kserve repo! kserve/models-web-app#33

Will close out the PR as the changes have been moved to kserve repo as recommended by #2151 (comment)

@annajung annajung closed this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants