remove kfserving component

[surajkota]

Description of your changes:

• remove kfserving component
• tests being updated to use kserve in Use KServe component in tests instead of KFServing #2164

Checklist:

• testing kustomize build example works

[kimwnasptd]

@surajkota could you also update the kustomization.yaml we have for KServe and only include the kserve_kubeflow.yaml file?

We had previously used the kserve.yaml and the extra aggregated roles because we had to install KFServing in the kubeflow namespace and KServe standalone. But we needed the aggregated roles so that's why we had manually added them.

But these are already included in the kserve_kubeflow.yaml, so we can completely remove them now https://github.com/kubeflow/manifests/blob/master/contrib/kserve/kserve/kserve_kubeflow.yaml#L12262-L12351

[juliusvonkohout]

@kimwnasptd i think kserve shoud be moved from https://github.com/kubeflow/manifests/tree/master/contrib/kserve to https://github.com/kubeflow/manifests/apps/kserve

The contrib folder is in general not maintained well. At least feast, application, metacontroller/base and tektoncd can most likely be deleted entirely. There are even more folders that have not been touched for 16-17 months.

[surajkota]

@kimwnasptd see #2240 for the updates related to kserve you requested

Also, ^^ makes sense. kserve is default app shipped with every kubeflow release. we could make that change

[kimwnasptd]

Thank you @surajkota!

@kimwnasptd i think kserve shoud be moved from https://github.com/kubeflow/manifests/tree/master/contrib/kserve to https://github.com/kubeflow/manifests/apps/kserve

The rationale was to keep only apps that live in the kubeflow/* org under apps, to have a clear distinction of the apps developed by Kubeflow and components that are external.

The contrib folder is in general not maintained well. At least feast, application, metacontroller/base and tektoncd can most likely be deleted entirely. There are even more folders that have not been touched for 16-17 months

This is a good orthogonal effort to start. We'll also need to add some requirements for components in contrib. Some initial things that come to mind are:

1. Expect the components to work with the latest KF versino
2. Clear instructions with how to integrate
3. Continued support (commits?) with a defined maximum window

But we can discuss this in a distinct issue for this effort

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kimwnasptd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment