Removed deprecated image override for dex #2283
Merged
+0
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dex image had been updated to a new registry in kubeflow#2243, thus, making this image override non-functional here. I propose removing it here (it's dead code anyhow) and letting only the deployment.yaml refer to the image in question.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd, lehrig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kevin85421
pushed a commit
to juliusvonkohout/manifests
that referenced
this pull request
Feb 28, 2023
The dex image had been updated to a new registry in kubeflow#2243, thus, making this image override non-functional here. I propose removing it here (it's dead code anyhow) and letting only the deployment.yaml refer to the image in question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dex image had been updated to a new registry in #2243, thus, making this image override non-functional here.
Description of your changes:
I propose removing it here (it's dead code anyhow) and letting only the deployment.yaml refer to the image in question.
Checklist:
Make sure you have installed kustomize == 3.2.1
make generate-changed-onlymake test