Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Anna Jung as reviewer #2378

Conversation

kimwnasptd
Copy link
Member

@kimwnasptd kimwnasptd commented Feb 2, 2023

Following up with another way overdue PR, for adding @annajung as a reviewer in both repo wide and in /contrib sub-directory.

Anna has made huge contributions to the manifests repo throughout the last 2 years. Some highlights:

  1. Helped shape and review the release handbook, that contained the release process for manifests First iteration of the Release Hanbook #1907
  2. Worked on the testing of manifests and how to setup an E2E infra (in-progress [doc]) Alternative solution to removal of test on optional-test-infra testing#1006 Update kubeflow/katib manifests from v0.14.0 #2273
  3. Has been a release manager for KF 1.6 and run the whole lifecycle of updating the manifests https://github.com/kubeflow/community/blob/master/releases/release-1.6/release-team.md
  4. Has lead the effort of cleaning up the /contrib repo Tracking for /contrib components evaluation and clean up #2311

The above contributions touch all the pillars of the manifests repo:

  1. Experience with the release process
  2. Overview of the testing infra
  3. Work/Reviewing the current addons we have

The above list, plus contributions on the common components owned by manifests (Istio, Knative, Cert Manager etc), is what I consider the main areas for promoting someone as an approver to the repo. And of course having a track record of being able to efficiently communicate and lead efforts in this areas.

So with the above I propose Anna to be a reviewer for both /contrib and for the whole repo

/cc @kubeflow/wg-manifests-leads

NOTE: I'm removing the current reviewers, since they are already in the approvers list

Signed-off-by: Kimonas Sotirchos <[email protected]>
@kimwnasptd
Copy link
Member Author

/approve cancel

I also want to say that we'll need to do a better job at defining the requirements for someone to be a subproject owner (approver in root OWNERS file of a repo). I think this is an area that is very hazy. Maybe this could be done in kubeflow/community#591

@google-oss-prow google-oss-prow bot removed the approved label Feb 2, 2023
@annajung
Copy link
Member

annajung commented Feb 2, 2023

Thanks @kimwnasptd! I hope other community members will also support this decision. Look forward to continuing the work on improving the overall integration and testing of the kubeflow and the Kubeflow release!

@DomFleischmann
Copy link
Contributor

Just want to give my +1 on this, Anna has been a great contributor to the project.

@elikatsis
Copy link
Member

Really happy that we more people are getting involved with this WG! @kimwnasptd I agree with your rationale, and @annajung definitely fits these requirements to be a reviewer.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elikatsis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9dfa66e into kubeflow:master Feb 14, 2023
@kimwnasptd kimwnasptd deleted the feature-kimwnasptd-manifests-anna-reviewer branch February 14, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants