fix(backend): stop heartbeat status updates for ScheduledWorkflows. F…

…ixes #8757 (#11363) * fix(backend): stop heartbeat status updates in ScheduledWorkflow controller. Fixes #8757 Signed-off-by: demarna1 <[email protected]> * Update scheduled_workflow_test.go Signed-off-by: demarna1 <[email protected]> --------- Signed-off-by: demarna1 <[email protected]>
kubeflow · Nov 26, 2024 · 9ccec4c · 9ccec4c
1 parent 94a21cc
commit 9ccec4c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/backend/src/crd/controller/scheduledworkflow/util/scheduled_workflow.go b/backend/src/crd/controller/scheduledworkflow/util/scheduled_workflow.go
@@ -271,7 +271,10 @@ func (s *ScheduledWorkflow) UpdateStatus(updatedEpoch int64, submitted bool,
 	scheduledEpoch int64, active []swfapi.WorkflowStatus,
 	completed []swfapi.WorkflowStatus, location *time.Location) {
 
-	updatedTime := metav1.NewTime(time.Unix(updatedEpoch, 0).UTC())
+	// updatedEpoch contains current time but using current time causes the
+	// SWF to fail to be reconciled by the controller. Set LastProbeTime and
+	// LastTransitionTime to 0 to avoid the irreconcilable status updates.
+	updatedTime := metav1.NewTime(time.Unix(0, 0).UTC())
 
 	conditionType, status, message := s.getStatusAndMessage(len(active))
 

diff --git a/backend/src/crd/controller/scheduledworkflow/util/scheduled_workflow_test.go b/backend/src/crd/controller/scheduledworkflow/util/scheduled_workflow_test.go
@@ -510,7 +510,7 @@ func TestScheduledWorkflow_GetNextScheduledEpoch_PeriodicSchedule(t *testing.T)
 func TestScheduledWorkflow_GetNextScheduledEpoch_UpdateStatus_NoWorkflow(t *testing.T) {
 	// Must run now
 	scheduledEpoch := int64(10 * hour)
-	updatedEpoch := int64(11 * hour)
+	updatedEpoch := int64(0)
 	creationTimestamp := metav1.NewTime(time.Unix(9*hour, 0).UTC())
 
 	schedule := NewScheduledWorkflow(&swfapi.ScheduledWorkflow{
@@ -591,7 +591,7 @@ func createStatus(workflowName string, scheduledEpoch int64) *swfapi.WorkflowSta
 func TestScheduledWorkflow_GetNextScheduledEpoch_UpdateStatus_WithWorkflow(t *testing.T) {
 	// Must run now
 	scheduledEpoch := int64(10 * hour)
-	updatedEpoch := int64(11 * hour)
+	updatedEpoch := int64(0)
 	creationTimestamp := metav1.NewTime(time.Unix(9*hour, 0).UTC())
 
 	schedule := NewScheduledWorkflow(&swfapi.ScheduledWorkflow{