Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] Forbid unarchive runs action if the run belongs to archived experiment #7014

Closed
difince opened this issue Dec 7, 2021 · 2 comments · Fixed by #7147
Closed

[backend] Forbid unarchive runs action if the run belongs to archived experiment #7014

difince opened this issue Dec 7, 2021 · 2 comments · Fixed by #7147
Assignees
@difince
Labels
help wanted The community is welcome to contribute. kind/feature

Comments

@difince
Copy link
Member

difince commented Dec 7, 2021

Feature Area

</area backend>

What feature would you like to see?

Add backend validation so that the user cannot activate a Run if it belongs to Archived Experiment.
When unarchive endpoint is called, check if the Run is under an Archived Experiment. If so, return an error 412 Precondition Failed

What is the use case or pain point?

In this issue-comment, it was concluded that Archived Experiment cannot contain Active Runs. This raises the need for such validation.

Is there a workaround currently?

Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
@difince
Copy link
Member Author

difince commented Dec 7, 2021

/assign @difince

@difince difince changed the title [backend] <Description> [backend] Forbid unarchive run's action if it belongs to archived experiment Dec 7, 2021
@difince difince changed the title [backend] Forbid unarchive run's action if it belongs to archived experiment [backend] Forbid unarchive runs action if the run belongs to archived experiment Dec 7, 2021
@zijianjoy zijianjoy added the help wanted The community is welcome to contribute. label Dec 10, 2021
@zijianjoy
Copy link
Collaborator

This behavior sounds good to us, feel free to contribute to this fix!

difince added a commit to difince/pipelines that referenced this issue Jan 7, 2022
@difince
[backend] Forbid unarchive runs that belog to archived experiment
23f21b9 
Adds validation so that the user cannot activate a Run that belongs to Archived Experiment.

Issue: kubeflow#7014

Signed-off-by: Diana Atanasova <[email protected]>
@difince difince mentioned this issue Jan 7, 2022
Merged
1 task
difince added a commit to difince/pipelines that referenced this issue Jan 7, 2022
@difince
[backend] Forbid unarchive runs that belog to archived experiment
8a02968 
Adds validation so that the user cannot activate a Run that belongs to Archived Experiment.

Issue: kubeflow#7014

Signed-off-by: Diana Atanasova <[email protected]>
google-oss-prow bot pushed a commit that referenced this issue Feb 9, 2022
@difince
feat(backend): Forbid unarchive runs that belog to archived experiment (
96a6a3b 
#7147)

* [backend] Forbid unarchive runs that belog to archived experiment

Adds validation so that the user cannot activate a Run that belongs to Archived Experiment.

Issue: #7014

Signed-off-by: Diana Atanasova <[email protected]>

* Change the err message to be more action-driven

Signed-off-by: Diana Atanasova <[email protected]>
abaland pushed a commit to abaland/pipelines that referenced this issue May 29, 2022
@difince @abaland
feat(backend): Forbid unarchive runs that belog to archived experiment (
4e4cb37 
kubeflow#7147)

* [backend] Forbid unarchive runs that belog to archived experiment

Adds validation so that the user cannot activate a Run that belongs to Archived Experiment.

Issue: kubeflow#7014

Signed-off-by: Diana Atanasova <[email protected]>

* Change the err message to be more action-driven

Signed-off-by: Diana Atanasova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@difince difince

Labels
help wanted The community is welcome to contribute. kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(backend): Forbid unarchive runs that belog to archived experiment difince/pipelines
2 participants
@difince @zijianjoy