feat(backend): Forbid unarchive runs that belog to archived experiment #7147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds validation so that the user cannot activate a Run that belongs to Archived Experiment. Issue: kubeflow#7014 Signed-off-by: Diana Atanasova <[email protected]>
difince
force-pushed
the
run_unarchived_validation
branch
from
23f21b9 to
8a02968
Compare
|
/retest |
zijianjoy
reviewed
Jan 16, 2022
Signed-off-by: Diana Atanasova <[email protected]>
|
/lgtm Thank you Diana! |
|
@zijianjoy May I ask if there is some problem? I haven't got any comments for a while but the PR still stays open ... |
|
/approve Hello Diana, approving this PR as it looks good to me. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abaland
pushed a commit
to abaland/pipelines
that referenced
this pull request
May 29, 2022
kubeflow#7147) * [backend] Forbid unarchive runs that belog to archived experiment Adds validation so that the user cannot activate a Run that belongs to Archived Experiment. Issue: kubeflow#7014 Signed-off-by: Diana Atanasova <[email protected]> * Change the err message to be more action-driven Signed-off-by: Diana Atanasova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation so that the user cannot activate a Run that belongs to Archived Experiment.
Fixes: #7014
Signed-off-by: Diana Atanasova [email protected]
Description of your changes:
Checklist: