Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): reduce executor logs #11169

Merged
merged 2 commits into from
Sep 6, 2024
Merged

(fix): reduce executor logs #11169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87db4c9
remove driver logs from executor
HumairAK Sep 5, 2024
c8328bf
remove duplicate emissary call in executor
HumairAK Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion backend/src/v2/component/launcher_v2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ func NewLauncherV2(ctx context.Context, executionID int64, executorInputJSON, co
if err != nil {
return nil, fmt.Errorf("failed to unmarshal executor input: %w", err)
}
glog.Infof("input ComponentSpec:%s\n", prettyPrint(componentSpecJSON))
component := &pipelinespec.ComponentSpec{}
err = protojson.Unmarshal([]byte(componentSpecJSON), component)
if err != nil {
Expand Down
3 changes: 0 additions & 3 deletions backend/src/v2/driver/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,6 @@ func initPodSpecPatch(
userCmdArgs = append(userCmdArgs, container.Command...)
userCmdArgs = append(userCmdArgs, container.Args...)
launcherCmd := []string{
// TODO(Bobgy): workaround argo emissary executor bug, after we upgrade to an argo version with the bug fix, we can remove the following line.
// Reference: https://github.com/argoproj/argo-workflows/issues/7406
"/var/run/argo/argoexec", "emissary", "--",
component.KFPLauncherPath,
// TODO(Bobgy): no need to pass pipeline_name and run_id, these info can be fetched via pipeline context and pipeline run context which have been created by root DAG driver.
"--pipeline_name", pipelineName,
Expand Down
Loading