Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): remove usage of deprecated commonLabels in Kustomize manifests #11289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

etheleon
Copy link

@etheleon etheleon commented Oct 12, 2024

Description of your changes:

Removed commonLabels since it's deprecated in Kustomize's api/v0.16.0 release. In it's place labels and selectors should be mentioned explicitly in the resource.

Checklist:

Copy link

Hi @etheleon. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@etheleon
Copy link
Author

resolves #11272

@etheleon
Copy link
Author

running grep -r "commonLabels" does not return any file

@etheleon etheleon marked this pull request as ready for review October 16, 2024 05:17
@etheleon
Copy link
Author

/verify-owners

@hbelmiro
Copy link
Contributor

/ok-to-test
/rerun-all

@HumairAK HumairAK added this to the KFP 2.4.0 milestone Oct 16, 2024
@DharmitD
Copy link
Contributor

@HumairAK could you approve the workflow runs? ty!

@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Oct 16, 2024
@github-actions github-actions bot removed the ci-passed All CI tests on a pull request have passed label Oct 16, 2024
@etheleon
Copy link
Author

hi @hbelmiro I've removed the redundant comments

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etheleon can you please sign-off your commits?

@hbelmiro
Copy link
Contributor

/ok-to-test
/rerun-all

@hbelmiro
Copy link
Contributor

hbelmiro commented Nov 1, 2024

@etheleon did you had the chance to see my comments here?
#11289 (review)

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @etheleon.
You still need to sign off your commits.

@etheleon
Copy link
Author

etheleon commented Nov 5, 2024

Thank you @etheleon. You still need to sign off your commits.

Let me rebase and sign off thanks for reminding

Used `kustomize edit fix  --vars`

Signed-off-by: etheleon <[email protected]>
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @HumairAK

@hbelmiro
Copy link
Contributor

@HumairAK @chensun
Can we merge this if it makes sense to you? Otherwise, could you please share your feedback so the author can work on it on time for KFP 2.4?

@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed All CI tests on a pull request have passed lgtm ok-to-test size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants