Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): Created Snowflake data unload component #11349

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

ChaosEternal
Copy link
Contributor

Added a component that talks to the snowflake database to do data unload to gcs bucket.

Copy link

Hi @ChaosEternal. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chensun
Copy link
Member

chensun commented Nov 1, 2024

@ChaosEternal can you please sign the DCO following: https://github.com/kubeflow/pipelines/pull/11349/checks?check_run_id=32381868852

Also this should be place under <repo_root>/components/snowflake, contrib folder is holding legacy components without active maintainers.

@chensun chensun requested review from chensun and removed request for neuromage and IronPan November 1, 2024 16:36
@chensun chensun self-assigned this Nov 1, 2024
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Dec 2, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 22e7780 into kubeflow:master Dec 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants