Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support leader election mechanism for Spark operator HA #511

Closed
wants to merge 2 commits into from

Conversation

tkanng
Copy link
Contributor

@tkanng tkanng commented Jun 9, 2019

Hi, this PR adds support for leader election mechanism for Spark operator HA by utilizing leaderelection, according to #458.

@tkanng
Copy link
Contributor Author

tkanng commented Jun 9, 2019

I'm not sure this implementation is good enough, for the reason that leaderelection is an alpha API. So please help me check it again. Thanks!

@liyinan926
Copy link
Collaborator

@tkanng thanks for working on this! I have the same concern that the leader election API is alpha and may change significantly in the future. I don't think the master branch is a good place for this change. A new branch forked from the master seems a better home for this PR and gives people a way to build and test this.

@michalzxc
Copy link

I have high hopes for this. Right now if you will delete spark operator pod, all spark jobs will remain broken until you will edit them and remove "status" section.
Deploying new version, spot instance termination, any operation what makes spark operator pod recreated breaks all sparkapplications

@tkanng
Copy link
Contributor Author

tkanng commented Jun 12, 2019

@liyinan926 Thanks for your comments! I'll close this pr soon. Would it be great to add a section to design.md or developer-guide.md about HA support? If so, I'd like to do it.

@liyinan926
Copy link
Collaborator

@tkanng yes, a section in design.md or developer-guide.md sounds great.

@tkanng
Copy link
Contributor Author

tkanng commented Jun 15, 2019

close it, via #522 .
Thank you for your patience!.

@tkanng tkanng closed this Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants