-
Notifications
You must be signed in to change notification settings - Fork 686
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove
table-logger
dependency (#1544)
Closes #1446. This removes the dependency on `table-logger`. None of the various alternatives mentioned in that issues were drop-in replacements, so given the simplicity of the use case here the dependency is replaced with a small class utilizing `str.format`. Note that the class was written without referring to the `table-logger` source at all, which would be a license violation. I confirmed that you can now run the sample notebook https://github.com/kubeflow/training-operator/blob/6523d8d2b7a27f1140a05971843cc4da7523694f/sdk/python/examples/kubeflow-tfjob-sdk.ipynb in modern IPython.
- Loading branch information
Showing
4 changed files
with
19 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,5 +4,4 @@ python_dateutil>=2.5.3 | |
setuptools>=21.0.0 | ||
urllib3>=1.15.1 | ||
kubernetes>=12.0.0 | ||
table_logger>=0.3.5 | ||
retrying>=1.3.3 |