-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve the "installing kubeflow" page #3381
improve the "installing kubeflow" page #3381
Conversation
@jbottum @annajung @DomFleischmann @zijianjoy I think this improvement will help users get started with kubeflow more easily, so would appreciate a review as soon as possible! /assign @jbottum @annajung @DomFleischmann @zijianjoy |
@thesuperzapper thank you for these proposed updates. I see follow-up in two parts - one for the distribution listing and one on the Raw naming convention. I propose that Brad Cardwell (distribution liaison for KF v1.7) might want to help organize the distribution approvals from the distributions. Initially the Oracle and Openshift contacts should weight in, but I think this impacts all of the distributions. It is a good topic / proposal for the Kubeflow Summit session today and we will give it some exposure. As for the raw naming, I initially ok with it but would like to hear what other comments might be. |
@VaishnaviHire Is there someone from the OpenShift team that would like to comment on this proposal ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I think it makes sense to move the distributions that are no longer supported into the "legacy" section.
Left a few comments on a few concerns with what defines as "active" vs "legacy" and version removal
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quick update, I have improved the bullet point symbols after the discussion in #3381 (comment), see the screenshot at the top of the page. |
Hello:) It is great you addressed this. One thing that has been raised in the past is the order that distributions are listed (based on this proposal in the Active distributions one). Is there any reason behind this? Might be more efficient to list them alphabetically. |
@andreeamun I have left the order as it was for this PR, I think we can discuss the best (and more fair) ordering in a separate discussion. I also think we need to confirm the "names" of distributions. The current names stem from a time when the community owned all the distributions. Now that the distributions are maintained externally, having them all called Perhaps we should encourage distributions to name themselves something completely different, or suggest EDIT: the other name we can suggest is |
@zijianjoy and @annajung what do you think we need to get this merged? I think the overall changes make the "installing kubeflow" page much easier to understand. |
@thesuperzapper I am still concerned about the removal of the versions. Without the versions listed, tracking which Kubeflow versions each distribution support would be harder. In the future, how would we be able to determine which distributions are active vs. inactive without adding the manual work to check their external doc? Wouldn't it be better to keep this page as the source of truth and work with distributions to update it? In addition, there is an open question about if all distributions listed in the "active" section support 1.6 that needs to be resolved before we can merge this PR. If the initial goal is to separate active and inactive, I think you can still move forward by keeping the versions as is and just separating the distributions that support 1.3 and below (more than 12months+). wdyt? |
Some comments, 1) I expect we will have additional distributions: VMware, HP, Civo, DKube/OneConvergence, 2) as the list gets longer, it will be harder to keep updated, especially if we are displaying version numbers. 3) I like version numbers, but in reality, distributions will modify (so does the version number mean as much i.e. Arrikto distribution has things that might eclipse 1.6, even if the are publicly stating on 1.x). |
@annajung @jbottum I have updated the PR with what I think is a good compromise.
In the future when we have "conformance testing" (kubeflow/kubeflow#6485), we can list which version of the Kubeflow "API" they are conformant with, which is more useful than listing "Kubeflow 1.X" as that is meaningless when we allow vendors to change anything they like about Kubeflow. |
@thesuperzapper @annajung Side note - perhaps instead of list distributions in alphabetical order, we list in order of date of 1st supported. This rewards the distributions that have been in the Community the longest and put them at the top of the list. Of course this assumes they have kept up with the subsequent releases. |
@jbottum I think let's leave the re-ordering discussion to a separate PR, so we can get this update merged soon. Note, I have left the order unchanged in this PR (other than moving some distributions to the new "legacy" table). EDIT: While I think we should discuss re-ordering in another PR, here are some more ideas for other metrics that we could order the table by:
|
I just did a quick formatting improvement in b1287ad:
Current Screenshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the kubeflow versions are replaced with the distributions' latest release date, can we make sure that all distributions list the dates?
tagging distribution owners for unknown values
<u><a href="https://www.arrikto.com/kubeflow-as-a-service/">Website</a></u> | ||
</td> | ||
<td> | ||
Unknown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kimwnasptd is there something we can reference here to add the date of your latest release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kimwnasptd just to clarify, we need a publicly listed blog/changelog/release-page that confirms the release date.
For example, I have used https://docs.arrikto.com/Changelog.html for the "Arrikto Enterprise Kubeflow" distribution, but "Arrikto Kubeflow as a Service" dose not seem to have an equivalent page.
<u><a href="https://github.com/oracle-devrel/kubeflow-oke">Website</a></u> | ||
</td> | ||
<td> | ||
Unknown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julioo is there something we can refer here to add the date of your latest release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julioo just to clarify, we need a publicly listed blog/changelog/release-page that confirms the release date so we can link it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annajung @thesuperzapper, you're referring to the Oracle Kubernetes Engine release date?
https://docs.oracle.com/en-us/iaas/releasenotes/services/conteng/
for example
https://docs.oracle.com/en-us/iaas/releasenotes/changes/2aca54a0-5594-48f3-8c51-c126d22d4eda/
I wanted to share another proposal for how to order the "installing kubeflow" table. I think we should sort the table alphabetically, but have separate tables for each "tier of partner" (think "platinum", "gold", and "silver"). Partners would attain tiers by accumulating points through their contributions and involvement in the project. For example, some things which could give you points might be:
We will probably need to treat "non-commercial" (free, open source) partners with a different set of standards so that we don't end up with commercial distributions crowding them out. Separately, we will need to rename distributions which are called things like In most cases, a rename to something like |
@johnugeorge Hey Johnu, this update show that Nutanix does not have a current distribution of Kubeflow. Would you please review and provide the correct info ? |
@thesuperzapper Hi Mathew - I believe your proposal on ordering and levels (especially using sweat equity) has merit. Per your/my earlier comments, I think that the re-ordering (and the distribution requirement restructuring) need to be in separate PRs. In the short term (by the end of the month or sooner), I propose that we need to add Oracle, Telekom, and Vmware and make sure the info listed for each distribution is correct. Question - Should we require a looks good to me from each of the distribution contacts before this is merged ? |
@thesuperzapper Nutanix supports Kubeflow 1.6 and was announced already kubeflow/manifests#2221 (comment). Please move it to active distributions. Ref: nutanix/karbon-platform-services#94 On a larger note, what are we aiming to achieve with this change? This change needs more discussion before merge. |
@johnugeorge I have updated the table to reflect this information in 98d74ba PS: I think it's a little strange to use a GitHub comment to announce a release, that's obviously up to Nutanix to decide how they do things.
This update is about a number of things (see the PR description), but primarily it's about making the tables more readable, and preparing for when this page will be the only reference to distributions on the |
@zijianjoy all Netelify builds are now failing because (we need to update the build image in the Netelify admin page), do you have access to update it? I have raised an issue to discuss this problem: #3404 |
@thesuperzapper, please push a new commit to trigger the tests |
98d74ba
to
eed8dc2
Compare
@gkcalat thanks for that! @annajung @liuqi I have rebased for #3396, however, I can't find a public announcement/changelog for Do you have a public place where you announced the release of For example, others are using the "releases" page on GitHub, or their official blog posts (a big goal of this PR is to have each distribution provide a "latest release date" with a link as evidence for this date). For @zijianjoy and everyone watching, here is a screenshot from this PR (as it currently stands). |
Hey all, I have created a new PR that makes the style changes, without removing the version // adding the release dates. Please help review #3440 |
This PR improves the
Getting Started / Installing Kubeflow
page in the following ways:Argoflow
(Kubeflow 1.4)Kubeflow on Azure
(Kubeflow 1.2)Removed the "version" column as it was quite messy, and often had incorrect information as distributions forgot to update it(replaced with "latest release" column)Kubeflow on OpenShift
-->Open Data Hub
Kubeflow on Oracle Container Engine for Kubernetes
-->Kubeflow on Oracle Cloud Infrastructure
Install a packaged Kubeflow distribution
-->Packaged Distributions of Kubeflow
Install the Kubeflow Manifests manually
-->Raw Kubeflow Manifests
Screenshot of the updated page: