Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gke: upgrade to 1.8.0 #3619

Merged
merged 1 commit into from
Nov 8, 2023
Merged

gke: upgrade to 1.8.0 #3619

merged 1 commit into from
Nov 8, 2023

Conversation

chensun
Copy link
Member

@chensun chensun commented Nov 7, 2023

terrytangyuan
terrytangyuan approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 8, 2023
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 746e719 into kubeflow:master Nov 8, 2023
6 checks passed
@chensun chensun deleted the gke18 branch November 8, 2023 18:45
@thesuperzapper
Copy link
Member

thesuperzapper commented Nov 9, 2023 •
edited
Loading

@chensun I think you may have forgotten to update the "installing kubeflow" page, which will also require you to update your "changelog" page on your website, as "Kubeflow on GCP" is still listed as 1.7.0.

website/content/en/docs/started/installing-kubeflow.md

Line 82 in 746e719

1.7.0 <sup>[<a href="https://googlecloudplatform.github.io/kubeflow-gke-docs/docs/changelog/#170">Release Notes</a>]</sup>

@chensun chensun mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@dsdinter dsdinter Awaiting requested review from dsdinter

Assignees

@terrytangyuan terrytangyuan

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chensun @thesuperzapper @terrytangyuan