Katib: Add Hyperparameter Tuning Architecture #3688
Conversation
Signed-off-by: Andrey Velichkevich <[email protected]>
|
Looks great! One small nit that is a testament to what an incorrigible pedant I am and therefore should probably just be ignored: the diagram uses CRD for experiments and trials and other custom resources when what's actually being created is a CR, not a CRD. Unfortunately, https://github.com/kubernetes/community/tree/master/icons doesn't provide a CR icon. |
|
Looks you can use an unlabeled CRD icon to reduce confusion: |
Signed-off-by: Andrey Velichkevich <[email protected]>
It's a good suggestion, thanks for review @droctothorpe! /hold cancel |
|
@droctothorpe: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, diegolovison, droctothorpe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related: kubeflow/katib#2255.
I added architecture of HP tuning task in Katib.
Also, I made changes for docs flow, please let me know what do you think about it.
/assign @tenzen-y @johnugeorge @gaocegege @kubeflow/release-team @diegolovison @hbelmiro @droctothorpe
/hold for review