-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creates a Template for new PRs #3965
Open
varodrig
wants to merge
10
commits into
kubeflow:master
Choose a base branch
from
varodrig:pull
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
41ca80c
update fix/broken links
varodrig 071c7fb
Merge branch 'kubeflow:master' into master
varodrig 3365730
Merge branch 'kubeflow:master' into master
varodrig 7d8d752
Merge branch 'kubeflow:master' into master
varodrig d9ae3b2
adding a template for PRs
varodrig fc5dac2
update centraldashboard label
varodrig c1c352d
update labels name
varodrig 606c6bd
update pr with labels
varodrig 47f718c
removing old label
varodrig 1a93757
add a comment about the component's title
varodrig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
<!-- Add the component name to the PR's title. Example: pipelines: Fixed broken link in Getting Started with Kubeflow Pipelines --> | ||
|
||
|
||
**Checklist:** | ||
- [ ] You have [signed off your commits](https://www.kubeflow.org/docs/about/contributing/#sign-off-your-commits) | ||
- [ ] Ensure you follow best practices from our guide. [Contributing](https://github.com/kubeflow/website/blob/master/content/en/docs/about/contributing.md). | ||
- [] You have included screenshots when changing the website style or adding a new page. | ||
|
||
|
||
**Description of your changes:** | ||
|
||
|
||
### Issue | ||
|
||
<!-- | ||
If this pull request resolves an open issue, please link the issue in the PR | ||
description so it will automatically close when the PR is merged. | ||
|
||
See the GitHub documentation for more details and other options: | ||
|
||
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword | ||
--> | ||
|
||
Closes: # | ||
|
||
<!--Additional Information:--> | ||
### Labels | ||
varodrig marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<!-- Please include labels below by uncommenting them to help us better review PRs --> | ||
|
||
<!-- /area central-dashboard --> | ||
<!-- /area katib --> | ||
<!-- /area kserve --> | ||
<!-- /area model-registry --> | ||
<!-- /area notebooks --> | ||
<!-- /area pipelines --> | ||
<!-- /area spark-operator --> | ||
<!-- /area trainer --> | ||
<!-- /area gsoc --> | ||
<!-- /area website --> | ||
<!-- /area community --> | ||
--- | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we create GitHub action that will check the PR title to make sure it aligns with the rules ?
I think, KFP has same check for their PR names:
https://github.com/kubeflow/pipelines/tree/master/.github/workflows