Formatting fixes (OVN-IC, PR template) #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting for the enumerated list for OVN-IC interconnection prerequisites is broken and does not render properly, because some indentation is missing (in the English version) and a blank line must be added (both versions). Add the missing indent and blank lines. Signed-off-by: Quentin Monnet <[email protected]>
The link to the conventions document is correct when reading it from the template files, but does not render properly in the browser, because we need to tell GitHub we're looking at a blob from the master branch. The main purpose for this template is to be rendered in the browser, so this is where the link should work correctly. Fix the URL to point to the right document, and add a second link to the English version of the document. Signed-off-by: Quentin Monnet <[email protected]>
oilbeater
approved these changes
Sep 9, 2024
|
Thanks! @qmonnet |
oilbeater
pushed a commit
that referenced
this pull request
Sep 10, 2024
* with-ovn-ic: Fix formatting for prerequisites list Formatting for the enumerated list for OVN-IC interconnection prerequisites is broken and does not render properly, because some indentation is missing (in the English version) and a blank line must be added (both versions). Add the missing indent and blank lines. Signed-off-by: Quentin Monnet <[email protected]> * .github: Fix Pull Request template links The link to the conventions document is correct when reading it from the template files, but does not render properly in the browser, because we need to tell GitHub we're looking at a blob from the master branch. The main purpose for this template is to be rendered in the browser, so this is where the link should work correctly. Fix the URL to point to the right document, and add a second link to the English version of the document. Signed-off-by: Quentin Monnet <[email protected]> --------- Signed-off-by: Quentin Monnet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with-ovn-ic: Fix formatting for prerequisites list
.github: Fix Pull Request template links
Make sure you have followed the Document Convention.