fix: should delete subnet before vpc (#4370)

Signed-off-by: bobz965 <[email protected]>
kubeovn · Aug 8, 2024 · 5baabfb · 5baabfb
1 parent 96e4aed
commit 5baabfb
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/pkg/controller/vpc.go b/pkg/controller/vpc.go
@@ -117,6 +117,13 @@ func (c *Controller) handleDelVpc(vpc *kubeovnv1.Vpc) error {
 	defer func() { _ = c.vpcKeyMutex.UnlockKey(vpc.Name) }()
 	klog.Infof("handle delete vpc %s", vpc.Name)
 
+	// should delete vpc subnets first
+	if len(vpc.Status.Subnets) != 0 {
+		err := fmt.Errorf("failed to delete vpc %s, still has subnets %v", vpc.Name, vpc.Status.Subnets)
+		klog.Error(err)
+		return err
+	}
+
 	if err := c.deleteVpcLb(vpc); err != nil {
 		klog.Error(err)
 		return err