ut: add unit test for ovn.go and ovs/util.go (#4440)

* add unit test for ovn Signed-off-by: zcq98 <[email protected]> * add unit test for ovs/util.go Signed-off-by: zcq98 <[email protected]> * fix: golangci-lint Signed-off-by: zcq98 <[email protected]> --------- Signed-off-by: zcq98 <[email protected]>
kubeovn · Aug 28, 2024 · add87ee · add87ee
1 parent 72cbfa5
commit add87ee
Show file tree

Hide file tree

Showing 2 changed files with 232 additions and 0 deletions.
diff --git a/pkg/ovs/ovn_test.go b/pkg/ovs/ovn_test.go
@@ -0,0 +1,44 @@
+package ovs
+
+import (
+	"testing"
+
+	"github.com/ovn-org/libovsdb/ovsdb"
+	"github.com/stretchr/testify/require"
+)
+
+func TestNewLegacyClient(t *testing.T) {
+	timeout := 30
+	client := NewLegacyClient(timeout)
+	require.NotNil(t, client)
+	require.Equal(t, timeout, client.OvnTimeout)
+}
+
+func TestConstructWaitForNameNotExistsOperation(t *testing.T) {
+	name := "test-name"
+	table := "test-table"
+	op := ConstructWaitForNameNotExistsOperation(name, table)
+
+	require.Equal(t, ovsdb.OperationWait, op.Op)
+	require.Equal(t, table, op.Table)
+	require.Equal(t, OVSDBWaitTimeout, *op.Timeout)
+	require.Equal(t, []ovsdb.Condition{{Column: "name", Function: ovsdb.ConditionEqual, Value: name}}, op.Where)
+	require.Equal(t, []string{"name"}, op.Columns)
+	require.Equal(t, string(ovsdb.WaitConditionNotEqual), op.Until)
+	require.Equal(t, []ovsdb.Row{{"name": name}}, op.Rows)
+}
+
+func TestConstructWaitForUniqueOperation(t *testing.T) {
+	table := "test-table"
+	column := "test-column"
+	value := "test-value"
+	op := ConstructWaitForUniqueOperation(table, column, value)
+
+	require.Equal(t, ovsdb.OperationWait, op.Op)
+	require.Equal(t, table, op.Table)
+	require.Equal(t, OVSDBWaitTimeout, *op.Timeout)
+	require.Equal(t, []ovsdb.Condition{{Column: column, Function: ovsdb.ConditionEqual, Value: value}}, op.Where)
+	require.Equal(t, []string{column}, op.Columns)
+	require.Equal(t, string(ovsdb.WaitConditionNotEqual), op.Until)
+	require.Equal(t, []ovsdb.Row{{column: value}}, op.Rows)
+}
diff --git a/pkg/ovs/util_test.go b/pkg/ovs/util_test.go
@@ -6,6 +6,8 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/require"
+
+	"github.com/kubeovn/kube-ovn/pkg/util"
 )
 
 func Test_parseIpv6RaConfigs(t *testing.T) {
@@ -56,6 +58,16 @@ func Test_parseDHCPOptions(t *testing.T) {
 		dhcpOpt := parseDHCPOptions("router=,test")
 		require.Empty(t, dhcpOpt)
 	})
+
+	t.Run("dns_server option with semicolons", func(t *testing.T) {
+		t.Parallel()
+		result := parseDHCPOptions("dns_server=8.8.8.8;8.8.4.4,server_id=192.168.1.1")
+		expected := map[string]string{
+			"dns_server": "8.8.8.8,8.8.4.4",
+			"server_id":  "192.168.1.1",
+		}
+		require.Equal(t, expected, result)
+	})
 }
 
 func Test_getIpv6Prefix(t *testing.T) {
@@ -230,6 +242,16 @@ func Test_OrAclMatch_Match(t *testing.T) {
 		_, err := match.Match()
 		require.ErrorContains(t, err, "acl rule key is required")
 	})
+
+	t.Run("error propagation", func(t *testing.T) {
+		t.Parallel()
+		match := NewOrACLMatch(
+			NewACLMatch("", "", "", ""),
+		)
+		_, err := match.Match()
+		require.Error(t, err)
+		require.Contains(t, err.Error(), "acl rule key is required")
+	})
 }
 
 func Test_Limiter(t *testing.T) {
@@ -319,4 +341,170 @@ func Test_Limiter(t *testing.T) {
 		require.ErrorContains(t, err, "context canceled by timeout")
 		require.Equal(t, int32(2), limiter.Current())
 	})
+
+	t.Run("default limit", func(t *testing.T) {
+		t.Parallel()
+
+		limiter := new(Limiter)
+		require.Equal(t, int32(0), limiter.Limit())
+	})
+}
+
+func TestPodNameToPortName(t *testing.T) {
+	t.Parallel()
+
+	testCases := []struct {
+		name      string
+		pod       string
+		namespace string
+		provider  string
+		expected  string
+	}{
+		{
+			name:      "OvnProvider",
+			pod:       "test-pod",
+			namespace: "default",
+			provider:  util.OvnProvider,
+			expected:  "test-pod.default",
+		},
+		{
+			name:      "NonOvnProvider",
+			pod:       "test-pod",
+			namespace: "kube-system",
+			provider:  "custom-provider",
+			expected:  "test-pod.kube-system.custom-provider",
+		},
+	}
+
+	for _, tc := range testCases {
+		tc := tc
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+			result := PodNameToPortName(tc.pod, tc.namespace, tc.provider)
+			require.Equal(t, tc.expected, result)
+		})
+	}
+}
+
+func TestTrimCommandOutput(t *testing.T) {
+	t.Parallel()
+
+	testCases := []struct {
+		name     string
+		input    []byte
+		expected string
+	}{
+		{
+			name:     "Whitespace only",
+			input:    []byte("   \t\n"),
+			expected: "",
+		},
+		{
+			name:     "Quoted string",
+			input:    []byte(`"Hello, World!"`),
+			expected: "Hello, World!",
+		},
+		{
+			name:     "Unquoted string with spaces",
+			input:    []byte("  Hello, World!\t\n"),
+			expected: "Hello, World!",
+		},
+		{
+			name:     "Single quotes",
+			input:    []byte(`'Hello, World!'`),
+			expected: "'Hello, World!'",
+		},
+		{
+			name:     "Newlines and tabs",
+			input:    []byte("\t\"Hello,\nWorld!\"\n"),
+			expected: "Hello,\nWorld!",
+		},
+	}
+
+	for _, tc := range testCases {
+		tc := tc
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+			result := trimCommandOutput(tc.input)
+			require.Equal(t, tc.expected, result)
+		})
+	}
+}
+
+func TestLogicalRouterPortName(t *testing.T) {
+	t.Parallel()
+
+	testCases := []struct {
+		name     string
+		lr       string
+		ls       string
+		expected string
+	}{
+		{
+			name:     "Standard case",
+			lr:       "router1",
+			ls:       "switch1",
+			expected: "router1-switch1",
+		},
+		{
+			name:     "Names with special characters",
+			lr:       "router-1",
+			ls:       "switch_1",
+			expected: "router-1-switch_1",
+		},
+		{
+			name:     "Long names",
+			lr:       "very_long_router_name_123456789",
+			ls:       "extremely_long_switch_name_987654321",
+			expected: "very_long_router_name_123456789-extremely_long_switch_name_987654321",
+		},
+	}
+
+	for _, tc := range testCases {
+		tc := tc
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+			result := LogicalRouterPortName(tc.lr, tc.ls)
+			require.Equal(t, tc.expected, result)
+		})
+	}
+}
+
+func TestLogicalSwitchPortName(t *testing.T) {
+	t.Parallel()
+
+	testCases := []struct {
+		name     string
+		lr       string
+		ls       string
+		expected string
+	}{
+		{
+			name:     "Standard case",
+			lr:       "router1",
+			ls:       "switch1",
+			expected: "switch1-router1",
+		},
+		{
+			name:     "Names with special characters",
+			lr:       "router-1",
+			ls:       "switch_1",
+			expected: "switch_1-router-1",
+		},
+		{
+			name:     "Long names",
+			lr:       "very_long_router_name_123456789",
+			ls:       "extremely_long_switch_name_987654321",
+			expected: "extremely_long_switch_name_987654321-very_long_router_name_123456789",
+		},
+	}
+
+	for _, tc := range testCases {
+		tc := tc
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+			result := LogicalSwitchPortName(tc.lr, tc.ls)
+			require.Equal(t, tc.expected, result)
+		})
+	}
 }