refactor: make qos test cases parallel #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane965
force-pushed
the
refactor-qos-policy
branch
4 times, most recently
from
49c5699
to
3711b1f
Compare
bobz965
requested changes
Jun 20, 2023
Split test cases to make them run in parallel. Reduce running time from 9 minutes to 4 minutes when iperf test is enabled.
shane965
force-pushed
the
refactor-qos-policy
branch
from
3711b1f
to
5841cae
Compare
bobz965
approved these changes
Jun 20, 2023
|
@zhangzujian, hi, could you help review this e2e ? |
zhangzujian
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split test cases to make them run in parallel.
Reduce running time from 9 minutes to 4 minutes when iperf test is enabled.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT
🤖 Generated by Copilot at d650075
Refactored the code for generating statefulset names for vpc nat gateways and improved the e2e tests. Moved the
genNatGwStsNamefunction from thecontrollerpackage to theutilpackage and renamed it toGenNatGwStsName. Used theutil.GenNatGwStsNamefunction invpc_nat_gateway.goandgc.go. Added aWaitGwPodReadyfunction to theframeworkpackage and modified theCreateSyncfunction invpc-nat-gw.go.🤖 Generated by Copilot at d650075
HOW
🤖 Generated by Copilot at d650075
genNatGwStsNamefunction toutilpackage (link, link, link, link, link, link, link)