Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cni-server: reconcile ovn0 routes periodically #2963

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jun 19, 2023

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #2962

WHAT

🤖 Generated by Copilot at dd1fac6

This pull request refactors some common logic for router reconciliation and enhances the subnet event handling and policy routing management in the daemon controller. It also fixes a nil pointer bug in controller_linux.go and removes an unnecessary function call in controller.go.

🤖 Generated by Copilot at dd1fac6

Sing, O Muse, of the cunning code reviewers
Who scanned the pull request with keen eyes
And praised the skillful mover of reconcileRouters
To a common file, where it could better serve the wise.

HOW

🤖 Generated by Copilot at dd1fac6

  • Move reconcileRouters function from controller_linux.go to controller.go to make it platform-independent and reusable (link)
  • Add nil check for event parameter in reconcileRouters to handle nil event case (link)
  • Fix bug by passing pointer to reconcileRouters instead of value to update original event object (link)
  • Add goroutine to periodically call reconcileRouters with nil event to ensure consistency of policy routing rules and routes (link)
  • Remove redundant call to runGateway in loopEncapIpCheck (link)

@zhangzujian zhangzujian added bug Something isn't working need backport labels Jun 19, 2023
@zhangzujian zhangzujian force-pushed the fix-ovn0-route branch 2 times, most recently from fcba19e to 7d9968d Compare June 19, 2023 09:55
@zhangzujian zhangzujian marked this pull request as ready for review June 19, 2023 10:06
@zhangzujian zhangzujian merged commit 33b6df1 into kubeovn:master Jun 19, 2023
54 of 56 checks passed
@zhangzujian zhangzujian deleted the fix-ovn0-route branch June 19, 2023 13:03
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

routes for overlay subnets on ovn0 are deleted after host network restarts
2 participants