skip NetworkManager unmanagement operations for bond devices automatically #2984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
set the nic could be managed by NetworkManager or not
Which issue(s) this PR fixes:
Fixes #2983
WHAT
🤖 Generated by Copilot at c8374a2
This pull request adds a new flag
--manage-nic-by-network-manager
to the ovn-cni container and a corresponding Helm valueMANAGE-NIC-BY-NETWORK-MANAGER
to the charts, which allow users to configure whether the ovn-cni plugin should set the network interface link managed by NetworkManager or not. This feature is intended to address the issue #1409, where some users reported network connectivity problems caused by NetworkManager interference.🤖 Generated by Copilot at c8374a2
HOW
🤖 Generated by Copilot at c8374a2
--manage-nic-by-network-manager
to the ovn-cni container arguments to allow users to configure NetworkManager management of network interface links (link)MANAGE-NIC-BY-NETWORK-MANAGER
to thenetworking
section invalues.yaml
to customize the flag value (link)ManageNicByNetworkManager
to theConfiguration
struct to store the flag value (link)pflag
package and assign it to the configuration field (link, link)SetManaged
method of thenmSyncer
object inchangeProvideNicName
andtransferAddrsAndRoutes
functions to pass the configuration field as the second argument, making the ovn-cni plugin respect the user's choice of NetworkManager management (link, link)