Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vlan subnet use logical gw can not access outside cluster node #3007

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

bobz965
Copy link
Collaborator

@bobz965 bobz965 commented Jul 3, 2023

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #2910

WHAT

🤖 Generated by Copilot at 2084e75

Simplify the condition for skipping subnets in reconcileRouters by removing a redundant check. Refactor the function to use a single loop for better performance and readability.

🤖 Generated by Copilot at 2084e75

reconcileRouters
Simpler condition, one loop
Autumn leaves fall fast

HOW

🤖 Generated by Copilot at 2084e75

  • Simplify the condition for skipping a subnet in reconcileRouters by removing the redundant subnet.Spec.LogicalGateway check (link)

@bobz965 bobz965 marked this pull request as ready for review July 3, 2023 06:54
@bobz965 bobz965 requested a review from zhangzujian July 3, 2023 06:54
@bobz965 bobz965 force-pushed the fix-underlay-route-to-ovn0 branch 3 times, most recently from ba1a285 to 6c870f5 Compare July 5, 2023 01:22
@zhangzujian zhangzujian added bug Something isn't working need backport labels Jul 5, 2023
@bobz965 bobz965 force-pushed the fix-underlay-route-to-ovn0 branch from 6c870f5 to a1e2b76 Compare July 5, 2023 09:41
@bobz965 bobz965 force-pushed the fix-underlay-route-to-ovn0 branch from 41639ce to 4e6633c Compare July 6, 2023 07:59
@bobz965 bobz965 force-pushed the fix-underlay-route-to-ovn0 branch from 4e6633c to 066f908 Compare July 7, 2023 03:34
@bobz965 bobz965 merged commit 5a5f66e into kubeovn:master Jul 7, 2023
@bobz965 bobz965 deleted the fix-underlay-route-to-ovn0 branch July 7, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

external network route via ovn0 cause br-external with ip can not access
2 participants