feat: suport kubevirt nic hotplug #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watermelon-brother
force-pushed
the
master
branch
from
423b509
to
c996ee5
Compare
1 task
|
The lint error should be fixed |
watermelon-brother
force-pushed
the
master
branch
from
c996ee5
to
49069ac
Compare
oilbeater
requested changes
Jul 12, 2023
pkg/daemon/ovs_linux.go
Outdated
| @@ -191,6 +191,10 @@ func generateNicName(containerID, ifname string) (string, string) { | |||
| if ifname == "eth0" { | |||
| return fmt.Sprintf("%s_h", containerID[0:12]), fmt.Sprintf("%s_c", containerID[0:12]) | |||
| } | |||
| if strings.HasPrefix(ifname, "pod") { | |||
There was a problem hiding this comment.
can you give a comment about why in some scenario the ifname will has prefix pod and exceed the length.
Signed-off-by: wujixin <[email protected]>
watermelon-brother
force-pushed
the
master
branch
from
49069ac
to
7ac7dc7
Compare
oilbeater
approved these changes
Jul 12, 2023
|
Thanks! @watermelon-brother |
|
backport "if" name starts with pod logic to release 1.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
kubevirt hotplug interface will cause kube-ovn create veth-pair.