Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split ippoolname and old ippool #3052

Closed
wants to merge 1 commit into from
Closed

Conversation

bobz965
Copy link
Collaborator

@bobz965 bobz965 commented Jul 19, 2023

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #3050

WHAT

🤖 Generated by Copilot at 1674ca4

Refactored the code to use a new annotation key util.IpPoolNameAnnotation for IP pool assignment and update for namespaces and pods. Added support for IP pools in dual stack subnets. Updated the test cases and constants accordingly.

🤖 Generated by Copilot at 1674ca4

Oh we're the crew of the kube-ovn
And we work on the code all day
We refactor the annotation key
To make the IP pools work our way

HOW

🤖 Generated by Copilot at 1674ca4

  • Refactor annotation keys for IP pools to use util.IpPoolNameAnnotation instead of util.IpPoolAnnotation for consistency and clarity (link, link, link, link, link, link, link)
  • Add support for specifying IP pools for pods in dual stack subnets by getting the IP pool name annotation from the pod if it exists (link, link)
  • Modify acquireAddress function in pkg/controller/pod.go to handle the case where the pod or the namespace has a single IP pool name annotation instead of a list of IP addresses and allocate an IP address from the IP pool by name using the GetRandomAddress method of the IPAM module (link)

@bobz965
Copy link
Collaborator Author

bobz965 commented Jul 19, 2023

it has another pr, so closed

@bobz965 bobz965 closed this Jul 19, 2023
@bobz965 bobz965 deleted the fix-ippool branch July 19, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipam: custom vpc: sts ip pool not use the static ipv6 address in ip pool annos
1 participant