Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovn client: fix sb chassis existence check #3072

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jul 25, 2023

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #3049

WHAT

🤖 Generated by Copilot at 49d6461

Simplify the logic of checking node chassis existence in ChassisExist function. Use string length instead of splitting output by newline characters.

🤖 Generated by Copilot at 49d6461

ChassisExist checks
Output of ovn-sbctl
Empty or not? - cold

HOW

🤖 Generated by Copilot at 49d6461

  • Simplify logic to check if node chassis exists in OVN southbound database (link)

@zhangzujian zhangzujian added bug Something isn't working need backport labels Jul 25, 2023
@zhangzujian zhangzujian merged commit 38cd920 into kubeovn:master Jul 25, 2023
59 checks passed
@zhangzujian zhangzujian deleted the fix-chassis branch July 25, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a bug in the method ChassisExist
2 participants